[webkit-reviews] review requested: [Bug 31851] [Qt] QWebInspector unusable on certain window managers : [Attachment 43811] Call setVisible from within the closeEvent

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 31851: [Qt] QWebInspector unusable on certain window managers
https://bugs.webkit.org/show_bug.cgi?id=31851

Attachment 43811: Call setVisible from within the closeEvent
https://bugs.webkit.org/attachment.cgi?id=43811&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
QWebInspector::hideEvent will call setVisible on the InspectorController
disabling/resetting certain views. E.g. on ion3 the hide event is called when
switching windows... so when going back to the QWebView every information is
gone..

The code could be changed to call it from within the closeEvent. This should
work for many usecases and in the worse case data of the InspectorController is
held in memory a bit longer.

For binary compability reasons I'm leaving an empty ::hideEvent in the code...