[webkit-reviews] review denied: [Bug 31838] Nested start/stop events in dispatchDidChangeLocationWithinPage for pages that do fragment redirect in window.onload : [Attachment 43780] Proposed patch.

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied  review:
Bug 31838: Nested start/stop events in dispatchDidChangeLocationWithinPage for
pages that do fragment redirect in window.onload
https://bugs.webkit.org/show_bug.cgi?id=31838

Attachment 43780: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=43780&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: third_party/WebKit/WebKit/chromium/src/FrameLoaderClientImpl.cpp
...
> +    // Flag of whether frame loader is completed. Generate didStartLoading
and
> +    // didStopLoading only when loader is completed so that we don't fire
> +    // them for fragment redirection that happens in window.onload handler.
> +    // See http://crbug.com/15782

nit: please link to the bugs.webkit.org bug instead.  that bug can have a
reference
to the chromium bug if you think it would be helpful.

also, you need to include a modification to WebCore/ChangeLog.	please see the
instructions here: http://webkit.org/coding/contributing.html