[webkit-reviews] review denied: [Bug 31822] [Chromium] Renderer hang when using www.expedia.com : [Attachment 43754] v1 patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 24 10:32:05 PST 2009


Adam Barth <abarth at webkit.org> has denied Darin Fisher (:fishd, Google)
<fishd at chromium.org>'s request for review:
Bug 31822: [Chromium] Renderer hang when using www.expedia.com
https://bugs.webkit.org/show_bug.cgi?id=31822

Attachment 43754: v1 patch
https://bugs.webkit.org/attachment.cgi?id=43754&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Talked with fishd via chat.  This change conflicts with a comment about how
originalRequest is supposed to be used.  Similar code in
SubResourceLoader::create user originalrequestcopy, so he's going to change to
use that instead.

Otherwise this seems fine to me, but this code is so complex I don't have very
high confidence.


More information about the webkit-reviews mailing list