[webkit-reviews] review denied: [Bug 31832] [Chromium] Inspector does not show resources loaded by plugins : [Attachment 43775] patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 31832: [Chromium] Inspector does not show resources loaded by plugins
https://bugs.webkit.org/show_bug.cgi?id=31832

Attachment 43775: patch
https://bugs.webkit.org/attachment.cgi?id=43775&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> +++ b/WebKit/chromium/public/WebDevToolsAgent.h
...
> +    virtual void identifierForInitialRequestForPlugin(int resourceId, const
WebURLRequest& request) = 0;
> +    virtual void willSendRequestForPlugin(int resourceId, const
WebURLRequest&) = 0;
> +    virtual void didReceiveDataForPlugin(int resourceId, int length) = 0;
> +    virtual void didReceiveResponseForPlugin(int resourceId, const
WebURLResponse& response) = 0;
> +    virtual void didFinishLoadingForPlugin(int resourceId) = 0;
> +    virtual void didFailLoadingForPlugin(int resourceId, const WebURLError&
error) = 0;

nit: in webkit style, you should exclude names for parameters if the name
doesn't add any information.  So, drop "request", "response", and "error"
above.


> +++ b/WebKit/chromium/public/WebFrame.h
...
> +    // Returns next unused request identifier which is unique within the
> +    // parent Page.
> +    virtual int createUniqueIdentifierForRequest() = 0;

This should be a method on WebView, not WebFrame.  WebView corresponds
to Page.