[webkit-reviews] review granted: [Bug 31826] [Qt] Make use of QNetworkReply::rawHeaderPairs : [Attachment 43758] Use the new API
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 24 10:13:36 PST 2009
Eric Seidel <eric at webkit.org> has granted Holger Freyther <zecke at selfish.org>'s
request for review:
Bug 31826: [Qt] Make use of QNetworkReply::rawHeaderPairs
https://bugs.webkit.org/show_bug.cgi?id=31826
Attachment 43758: Use the new API
https://bugs.webkit.org/attachment.cgi?id=43758&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Could you explain more about the quadratic runtime? It would be helpful to
have a better ChangeLog entry. The code itself looks sane, but it would be
much better to explain why this is a problem and how this is the right solution
for the problem in the ChangeLog.
r+, but cq- because the ChangeLog should be improved before landing (I expect
you plan to land this yourself anyway, but just to prevent any confusion that
this was good-to-go as is.)
More information about the webkit-reviews
mailing list