[webkit-reviews] review granted: [Bug 31780] Web Inspector: Keyboard Shortcut to Clear Console Messages : [Attachment 43776] [PATCH] Cmd+K (Mac), Ctrl+L (All) to Clear Console Using KeyboardShortcut

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 31780: Web Inspector: Keyboard Shortcut to Clear Console Messages
https://bugs.webkit.org/show_bug.cgi?id=31780

Attachment 43776: [PATCH] Cmd+K (Mac), Ctrl+L (All) to Clear Console Using
KeyboardShortcut
https://bugs.webkit.org/attachment.cgi?id=43776&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> +    var shortcut;

Move this lower?

> +	       if (!this._shortcuts[shortcut].isMacOnly ||
WebInspector.isMac()) {

We could make this logic a part of the makeKeyFromEvent, no?