[webkit-reviews] review denied: [Bug 31832] [Chromium] Inspector does not show resources loaded by plugins : [Attachment 43770] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 31832: [Chromium] Inspector does not show resources loaded by plugins
https://bugs.webkit.org/show_bug.cgi?id=31832

Attachment 43770: patch
https://bugs.webkit.org/attachment.cgi?id=43770&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> -void InspectorController::didFinishLoading(DocumentLoader*, unsigned long
identifier)
> +void InspectorController::didFinishLoading(unsigned long identifier)

This does not seem to be used. Should we call into it from
ResourceLoadNotifier::didFailToLoad?


> +    // Update load time.
> +    m_endTime = currentTime();
> +    m_changes.set(TimingChange);

Could you comment on why it is needed?

There are clearly two orthogonal changes in this patch: one for WebCore, one
for WebKit/chromium. Could you split them?