[webkit-reviews] review granted: [Bug 26354] [Gtk] GStreamer-CRITICAL's (and other warnings) on <video> : [Attachment 43757] Implemented MediaPlayerPrivate::isAvailable by checking the presence of the playbin2 GStreamer element.

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 26354: [Gtk] GStreamer-CRITICAL's (and other warnings) on <video>
https://bugs.webkit.org/show_bug.cgi?id=26354

Attachment 43757: Implemented MediaPlayerPrivate::isAvailable by checking the
presence of the playbin2 GStreamer element.
https://bugs.webkit.org/attachment.cgi?id=43757&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Good. Do you need someone to commit this, or you have commit privileges by now?


Some nits:

 163	 bool available = false;
 164	 GstElementFactory* factory;
 165 
 166	 do_gst_init();
 167	 factory = gst_element_factory_find("playbin2");

factory should only be declared here, where it is first used. Perhaps you can
also lose the available variable, and just return true inside the if (factory)
check, returning false otherwise.