[webkit-reviews] review requested: [Bug 31821] Type=number UI part 1: pseudo classes and appearances : [Attachment 43751] Proposed patch (rev.2)

[bugzilla-daemon at webkit.org]

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 31821: Type=number UI part 1: pseudo classes and appearances
https://bugs.webkit.org/show_bug.cgi?id=31821

Attachment 43751: Proposed patch (rev.2)
https://bugs.webkit.org/attachment.cgi?id=43751&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
* Improve ChangeLog
* Resolve conflicts

(In reply to comment #1)
> Comments on this part in Bug#27968:
> 
> ■■ Comment #12 From Eric Seidel 2009-09-23 10:31:35 PST (-) [reply] 
> (From update of attachment 39537 [details] [details])
> The change looks OK.	Where did the "*-spin-button" names come from?	What
does
> it have to do with spinning?	Can you post a picture of what these inputs are

> going to look like?
> 
> ■■ Comment #15 From Eric Seidel 2009-09-23 10:36:37 PST (-) [reply] 
> Why are these called spin buttons if the Mac APIs call them steppers?  Does
> windows call these "Spin buttons"?

Right.	Windows and GTK call such controls "spin buttons."
I don't have strong preference about the name.	However "Stepper" is Mac-only
uncommon.

> ■■ Comment #16 From Eric Seidel 2009-09-23 10:38:18 PST (-) [reply] 
> Why are they called inner and outer spin buttons if they're really up and
down
> steppers?  Please cite the spec, or talk about where these names came from. 
> Ideally in your ChangeLogs, since that's what reviewers read.

An inner or outer spin button represents a pair of a upper arrow button and a
lower arrow button.
An inner-spin-button will be placed at the inside of a text field (Windows'
standard style), and
an outer-spin-button will be placed at the outside of a text field (Mac's
standard style).

I added some sentences about this to ChangeLog.