[webkit-reviews] review requested: [Bug 31698] MessagePorts always look remotely entangled even when closed. : [Attachment 43748] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 23 21:51:32 PST 2009
Andrew Wilson <atwilson at chromium.org> has asked for review:
Bug 31698: MessagePorts always look remotely entangled even when closed.
https://bugs.webkit.org/show_bug.cgi?id=31698
Attachment 43748: proposed patch
https://bugs.webkit.org/attachment.cgi?id=43748&action=review
------- Additional Comments from Andrew Wilson <atwilson at chromium.org>
The old V8 GC code relied on the fact that a port could not be disentangled
during GC, which is clearly incorrect. I updated/simplified this code to do the
right thing now (add a reference to entangled ports at the start of GC, and
remove the reference from all referenced ports at the end).
More information about the webkit-reviews
mailing list