[webkit-reviews] review requested: [Bug 30091] Change get... calls to latest spec : [Attachment 43747] Revised patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 23 20:22:45 PST 2009


Kenneth Russell <kbr at google.com> has asked  for review:
Bug 30091: Change get... calls to latest spec
https://bugs.webkit.org/show_bug.cgi?id=30091

Attachment 43747: Revised patch
https://bugs.webkit.org/attachment.cgi?id=43747&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Merged with WebGL changes from earlier today.

Fixed problem in new test case where minification and magnification filters on
FBO's texture were not initialized. This is probably why the patch failed the
commit queue the first time.

Fixed bug in bounds checking logic in WebGLRenderingContext::activeTexture
uncovered by Google's WebGL demos. Made activeTexture raise DOMException per
spec and actually throw an exception to prevent this kind of error from being
silently squelched.


More information about the webkit-reviews mailing list