[webkit-reviews] review denied: [Bug 31239] c3d test crash WebKit : [Attachment 43736] Desperate attempt at acceptance patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 23 15:05:36 PST 2009


Oliver Hunt <oliver at apple.com> has denied Chris Marrin <cmarrin at apple.com>'s
request for review:
Bug 31239: c3d test crash WebKit
https://bugs.webkit.org/show_bug.cgi?id=31239

Attachment 43736: Desperate attempt at acceptance patch
https://bugs.webkit.org/attachment.cgi?id=43736&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
WebGLRenderingContext::validateIndexArray

has an else start on the line after }

You've removed the type checks from createShader, which is a bad thing.

r- mostly due to removing the type checks


More information about the webkit-reviews mailing list