[webkit-reviews] review granted: [Bug 31748] Make WebSocketHandleCFNet respect proxy auto-configuration files via CFProxySupport : [Attachment 43617] proposed patch

[bugzilla-daemon at webkit.org]

Brady Eidson <beidson at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 31748: Make WebSocketHandleCFNet respect proxy auto-configuration files via
CFProxySupport
https://bugs.webkit.org/show_bug.cgi?id=31748

Attachment 43617: proposed patch
https://bugs.webkit.org/attachment.cgi?id=43617&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
We can't layout test PAC stuff, can we?

r=me but...

> -struct MainThreadEventCallbackInfo {
> -    MainThreadEventCallbackInfo(CFStreamEventType type, SocketStreamHandle*
handle) : type(type), handle(handle) { }
> -    CFStreamEventType type;
> -    SocketStreamHandle* handle;
> -};
> +struct MainThreadEventCallbackInfo {
> +    MainThreadEventCallbackInfo(CFStreamEventType type, SocketStreamHandle*
handle) : type(type), handle(handle) { }
> +    CFStreamEventType type;
> +    SocketStreamHandle* handle;
> +};

Maybe I'm blind, I don't know why this diff exists.

>  #if PLATFORM(WIN)
> -void SocketStreamHandle::readStreamCallbackMainThread(void* invocation)
> -{
> -    MainThreadEventCallbackInfo* info =
static_cast<MainThreadEventCallbackInfo*>(invocation);
> -    info->handle->readStreamCallback(info->type);
> -}
> -
> -void SocketStreamHandle::writeStreamCallbackMainThread(void* invocation)
> -{
> -    MainThreadEventCallbackInfo* info =
static_cast<MainThreadEventCallbackInfo*>(invocation);
> -    info->handle->writeStreamCallback(info->type);
> -}
> +void SocketStreamHandle::readStreamCallbackMainThread(void* invocation)
> +{
> +    MainThreadEventCallbackInfo* info =
static_cast<MainThreadEventCallbackInfo*>(invocation);
> +    info->handle->readStreamCallback(info->type);
> +}
> +
> +void SocketStreamHandle::writeStreamCallbackMainThread(void* invocation)
> +{
> +    MainThreadEventCallbackInfo* info =
static_cast<MainThreadEventCallbackInfo*>(invocation);
> +    info->handle->writeStreamCallback(info->type);
> +}

Or this one.