[webkit-reviews] review denied: [Bug 30091] Change get... calls to latest spec : [Attachment 43641] Revised patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Kenneth Russell <kbr at google.com>'s
request for review:
Bug 30091: Change get... calls to latest spec
https://bugs.webkit.org/show_bug.cgi?id=30091

Attachment 43641: Revised patch
https://bugs.webkit.org/attachment.cgi?id=43641&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
The WebGLGetInfo::Type enum does not match the webkit style guidelines --
http://webkit.org/coding/coding-style.html -- They should be camel cased, with
Type as a prefix rather than T_

I don't like the CleanupHelper class changes -- i believe they can be made in
an independent patch the preceeds the main fix.  Currently there is a lot of
noise due to your updating every cleanupAfterGraphicsCall call site despite
those sites not actually being involved in what the patch is meant to be doing.


I really like the changes to GraphicsContext3D -- anything that removes DOM
objects from the platform layer is a good thing.  It's something of a mistake
that they were there to begin with.

I'd like to make those methods that depend on WebGLGetInfo to be automatically
generated, but i believe doing so would be to involved to require you to do.

Unfortunately you'll have to resolve the two issues i mentioned before i can r+
this.