[webkit-reviews] review denied: [Bug 31802] Switch Chrome on Mac to Core Text APIs : [Attachment 43704] Switch Chrome/Mac from ATSUI -> Core Text

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 23 07:44:29 PST 2009


Mark Rowe (bdash) <mrowe at apple.com> has denied Jeremy Moskovich
<playmobil at google.com>'s request for review:
Bug 31802: Switch Chrome on Mac to Core Text APIs
https://bugs.webkit.org/show_bug.cgi?id=31802

Attachment 43704: Switch Chrome/Mac from ATSUI -> Core Text
https://bugs.webkit.org/attachment.cgi?id=43704&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> diff --git a/WebCore/platform/graphics/SimpleFontData.h
b/WebCore/platform/graphics/SimpleFontData.h
> index 387a5c7..eb31f66 100644
> --- a/WebCore/platform/graphics/SimpleFontData.h
> +++ b/WebCore/platform/graphics/SimpleFontData.h
> @@ -115,7 +115,7 @@ public:
>      virtual String description() const;
>  #endif
>  
> -#if PLATFORM(MAC)
> +#if PLATFORM(DARWIN)
>      NSFont* getNSFont() const { return m_platformData.font(); }
>  #endif

NSFont is an AppKit level API, well above the Darwin layer.  It makes no sense
to bracket it with “PLATFORM(DARWIN)”.


More information about the webkit-reviews mailing list