[webkit-reviews] review requested: [Bug 31618] "using" statement coding style guidelines need clarification : [Attachment 43694] Revised patch

[bugzilla-daemon at webkit.org]

Chris Jerdonek <chris.jerdonek at gmail.com> has asked  for review:
Bug 31618: "using" statement coding style guidelines need clarification
https://bugs.webkit.org/show_bug.cgi?id=31618

Attachment 43694: Revised patch
https://bugs.webkit.org/attachment.cgi?id=43694&action=review

------- Additional Comments from Chris Jerdonek <chris.jerdonek at gmail.com>
I have incorporated Darin's comments.

A couple remarks:

1) I'm not sure if I interpreted the following suggestion correctly, after all:


> I think we need two different Wrong for the two different mistakes. Instead
it
> looked like a since Wrong case that demonstrated two errors. A reader might
> miss one or the other other.

I took this to mean to add a second "Wrong" header for the second mistake
instead of having a single "Wrong" header for both mistakes.  I'm not sure if
this is what was intended, though, since the rest of the Style Guidelines page
always uses a single "Wrong" header to illustrate mistakes -- even a group of
them.

2) Regarding Darin's information that JavaScriptGlue is a legacy component, I
added this information to the WebKit Wiki (
http://trac.webkit.org/wiki/HighLevelOverview ) instead of including it in this
patch.

Thanks.