[webkit-reviews] review denied: [Bug 30989] [Gtk, WML] Assert failure in http://wap.google.com/wml : [Attachment 43512] Patch with comments incorporated.

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Nayan <nayankk at gmail.com>'s
request for review:
Bug 30989: [Gtk, WML] Assert failure in http://wap.google.com/wml
https://bugs.webkit.org/show_bug.cgi?id=30989

Attachment 43512: Patch with comments incorporated.
https://bugs.webkit.org/attachment.cgi?id=43512&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
r- for the LayoutTest. I've tested your patch and it works fine, though the
testcase is flawed.
The purpose of using "createStaticWMLTestCase" is to create a testcase which
never leaves the target document (only switching cards is allowed, as the
existing onenterforward-* tests demonstrate). You need to dynamically create
the WML testcase, otherwhise testing refresh tasks is not possible (due the
reloads of the whole document, no one ever calls notifyDone).

The "wml/script-tests/input-format.js" uses a refresh task, and demonstrates
how to write tests for it. Can you please look into that to create a valid
testcase?