[webkit-reviews] review granted: [Bug 19103] Web inspector never shows the query part of URIs : [Attachment 43661] Patch to add a tooltip with the full URL with query parameters to each resource in the Resources Panel

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 21 17:11:28 PST 2009


Timothy Hatcher <timothy at hatcher.name> has granted Jessie Berlin
<jberlin at webkit.org>'s request for review:
Bug 19103: Web inspector never shows the query part of URIs
https://bugs.webkit.org/show_bug.cgi?id=19103

Attachment 43661: Patch to add a tooltip with the full URL with query
parameters to each resource in the Resources Panel
https://bugs.webkit.org/attachment.cgi?id=43661&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +	   this.tooltip = this.resource.url.escapeHTML();

You don't want escapeHTML here. This sets the title property in the DOM, so
escaping isn't needed (and would cause & to show as &amp;.

Fix that before landing.


More information about the webkit-reviews mailing list