[webkit-reviews] review granted: [Bug 31588] CSSKeyframesRule::findRule() and deleteRule() should accept 'from' and 'to' as well as percentages : [Attachment 43660] Patch v2.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Nov 21 15:45:59 PST 2009


mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 31588: CSSKeyframesRule::findRule() and deleteRule() should accept 'from'
and 'to' as well as percentages
https://bugs.webkit.org/show_bug.cgi?id=31588

Attachment 43660: Patch v2.
https://bugs.webkit.org/attachment.cgi?id=43660&action=review

------- Additional Comments from mitz at webkit.org
> +    if (key.lower() == "from")

I think the way this is typically done is using equalIgnoringCase, although I
thought there was also a special function for when one of the strings is known
to be all-lowercase, but I can’t find it right now.

r=me either way


More information about the webkit-reviews mailing list