[webkit-reviews] review requested: [Bug 31400] Web Inspector: Support Ctrl+P, Ctrl+N, and other Readline keyboard shortcuts in the Console : [Attachment 43648] [PATCH] Ctrl+P, Ctrl+N, Ctrl+U for Macs Only

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 31400: Web Inspector: Support Ctrl+P, Ctrl+N, and other Readline keyboard
shortcuts in the Console
https://bugs.webkit.org/show_bug.cgi?id=31400

Attachment 43648: [PATCH] Ctrl+P, Ctrl+N, Ctrl+U for Macs Only
https://bugs.webkit.org/attachment.cgi?id=43648&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
More explicit behavior in the switch. No fall throughs.

The only thing I am worried about is the O(n) behavior of deleting nodes in
clearBeforeCaret. Even though my tests showed it was immediate for a rather
large paste, I still think there should be a better way to delete a range of
nodes in 1 operation, rather then n. Any pointers?