[webkit-reviews] review denied: [Bug 31731] [Android] Android does not support ICU encoding x-mac-cyrillic : [Attachment 43598] Patch 1 for Bug 31731

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Steve Block
<steveblock at google.com>'s request for review:
Bug 31731: [Android] Android does not support ICU encoding x-mac-cyrillic
https://bugs.webkit.org/show_bug.cgi?id=31731

Attachment 43598: Patch 1 for Bug 31731
https://bugs.webkit.org/attachment.cgi?id=43598&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I don't think that this is quite right. Chromium also stripped x-mac-cyrillic
from ICU, but we don't have ifdefs for this in TextCodecICU.cpp.

We shouldn't be using different solutions for the same problem on different
platforms. On a higher level, it's still a mystery to me why Chromium and
Android go to such lengths to remove support for an encoding. See bug 21581 for
some earlier discussion.