[webkit-reviews] review canceled: [Bug 30282] Web Inspector: Add console only layout mode : [Attachment 43553] [PATCH] Console Panel (Even Better)

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has canceled Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 30282: Web Inspector: Add console only layout mode
https://bugs.webkit.org/show_bug.cgi?id=30282

Attachment 43553: [PATCH] Console Panel (Even Better)
https://bugs.webkit.org/attachment.cgi?id=43553&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
> More Todo (future patches):
> - Convert WebInspector.animateStyle to an Interval instead of Timeouts

Done.

Notes:
I refactored animateStyle to use setInterval. Some interesting points: the
original didn't actually use the "current" value anywhere. It determines the
current, it assigns it to variables, but those variables are never used
constructively, some not at all. I haven't looked into the history about this.
I just removed all the extra computations.

Because the Diff looks ugly you can view the new algorithm in color here:
http://pastie.textmate.org/private/kuuuktkk7jbfiph6fmnpdg

Video of current behavior:
http://screencast.com/t/NzE5YzFjZ

Sorry about the spam.