[webkit-reviews] review denied: [Bug 31704] [chromium] Add setCaretBlinkInterval API : [Attachment 43547] patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Joel Stanley
<joel at jms.id.au>'s request for review:
Bug 31704: [chromium] Add setCaretBlinkInterval API
https://bugs.webkit.org/show_bug.cgi?id=31704

Attachment 43547: patch
https://bugs.webkit.org/attachment.cgi?id=43547&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> +++ b/WebKit/chromium/src/WebViewImpl.cpp
...
> +void WebViewImpl::setCaretBlinkInterval(double interval) {
> +#if PLATFORM(LINUX)
> +   
reinterpret_cast<RenderThemeChromiumLinux*>(theme())->setCaretBlinkInterval(int
erval);
> +#endif
> +}

theme() actually returns a singleton, so mutating this singleton via
a WebView instance is a bit confusing since it would cause the value
to be changed for all WebView instances.

since this is Linux only, perhaps you should just create a linux specific
header file in public/linux that exposes a static setter for this propery.

-darin