[webkit-reviews] review requested: [Bug 30091] Change get... calls to latest spec : [Attachment 43541] Proposed patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has asked  for review:
Bug 30091: Change get... calls to latest spec
https://bugs.webkit.org/show_bug.cgi?id=30091

Attachment 43541: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=43541&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Removed old versions of get calls on WebGLRenderingContext and added new ones
per spec returning "any". New code simplifies GraphicsContext3D and fixes
previously unimplemented routines. Added custom JS and V8 bindings. Added
exhaustive test case exercising all new code paths. Updated preexisting test
cases for new APIs. Fixed preexisting bugs in WebKit's and Chrome's WebGL
implementations. Cleaned up a couple of areas from recent Canvas -> WebGL
renaming and deleted obsolete CanvasNumberArray.

Ran WebGL layout tests in WebKit (clean) and Chrome (couple of preexisting
known failures) and manual WebGL tests in both browsers.