[webkit-reviews] review denied: [Bug 31321] Make -webkit-color-correction work with untagged images : [Attachment 43321] New patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 19 12:48:42 PST 2009


Dave Hyatt <hyatt at apple.com> has denied Beth Dakin <bdakin at apple.com>'s request
for review:
Bug 31321: Make -webkit-color-correction work with untagged images
https://bugs.webkit.org/show_bug.cgi?id=31321

Attachment 43321: New patch
https://bugs.webkit.org/attachment.cgi?id=43321&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
I'd really like to see the color space be a default argument in the
GraphicsContext functions.  I'd love to see that change for say fillRect and
any others you may already have done also.

If you look at most of your calls, you're almost always passing in
DeviceColorSpace... if you put that argument at the end of the functions and
made it default, then it could be omitted, and you wouldn't have to patch a
bunch of call sites.


More information about the webkit-reviews mailing list