[webkit-reviews] review requested: [Bug 21288] Implement HTML5's sandbox attribute for iframes : [Attachment 43508] Patch with simplified storage/database sandboxing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 19 08:53:13 PST 2009


Patrik Persson <patrik.j.persson at ericsson.com> has asked  for review:
Bug 21288: Implement HTML5's sandbox attribute for iframes
https://bugs.webkit.org/show_bug.cgi?id=21288

Attachment 43508: Patch with simplified storage/database sandboxing
https://bugs.webkit.org/attachment.cgi?id=43508&action=review

------- Additional Comments from Patrik Persson <patrik.j.persson at ericsson.com>
To solve the short-term issue of client-side storage/databases in
sandboxes, this patch makes sandboxed frames work as if though
client-side storage/databases were disabled in Settings.

Changes:

* SecurityOrigin::equal() and SecurityOriginHash no longer know about
  sandboxing.

* DOMWindow attributes localStorage and sessionStorage are null in
  sandboxed frames.

* DOMWindow method openDatabase() returns null in sandboxed frames.

* Revised test case for sandboxed storage and database
  (LayoutTests/fast/frames/sandboxed-iframe-storage.html).


More information about the webkit-reviews mailing list