[webkit-reviews] review denied: [Bug 31656] -webkit-user-drag: element Drag images include overflow decorations from incorrect nodes : [Attachment 43484] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Oliver Hunt <oliver at apple.com>'s request for review:
Bug 31656: -webkit-user-drag: element Drag images include overflow decorations
from incorrect nodes
https://bugs.webkit.org/show_bug.cgi?id=31656

Attachment 43484: Patch
https://bugs.webkit.org/attachment.cgi?id=43484&action=review

------- Additional Comments from mitz at webkit.org
> +    if (hasOverflowClip() && style()->visibility() == VISIBLE && (phase ==
PaintPhaseBlockBackground || phase == PaintPhaseChildBlockBackground)) {
> +	   if (!paintInfo.paintingRoot ||
isDescendantOf(paintInfo.paintingRoot))
> +	       layer()->paintOverflowControls(paintInfo.context, tx, ty,
paintInfo.rect);
> +    }

Can’t use use shouldPaintWithinRoot? You are never supposed to be a proper
descendant of the painting root.

You should just add the test to the first if’s condition instead of nesting
like that.

It would be good to have a manual test case for this. I don’t think it
necessarily has to be checked in, but at least attach it to the bug, if
possible, for future reference.

r- because I think you don’t need to call isDescendantOf().