[webkit-reviews] review requested: [Bug 31637] Need to ASSERT(isMainThread()) in ThreadShared methods. : [Attachment 43471] Proposed patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 18 16:47:44 PST 2009


Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 31637: Need to ASSERT(isMainThread()) in ThreadShared methods.
https://bugs.webkit.org/show_bug.cgi?id=31637

Attachment 43471: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=43471&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
Added ASSERT to constructor, destructor, setParent, parent, ref and deref.

Measured run-webkit-tests on debug build - the difference is not measurable. On
my machine, it takes 11 min 20 sec, +/- 10 seconds from run to run, I can not
see the difference.


More information about the webkit-reviews mailing list