[webkit-reviews] review denied: [Bug 31634] Ignore realm for proxy protection spaces : [Attachment 43446] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 18 16:14:50 PST 2009
Darin Adler <darin at apple.com> has denied Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 31634: Ignore realm for proxy protection spaces
https://bugs.webkit.org/show_bug.cgi?id=31634
Attachment 43446: proposed patch
https://bugs.webkit.org/attachment.cgi?id=43446&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> + if (protectionSpace.isProxy())
> + codeCount -= sizeof(UChar);
Should be sizeof(hashCodes[0]) / sizeof(UChar) or some similar expression, not
sizeof(UChar).
More information about the webkit-reviews
mailing list