[webkit-reviews] review granted: [Bug 31601] Move showDebugBorders and showRepaintCounter to Settings/Preferences : [Attachment 43442] Replacement patch - gets rid of errant printfs

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 18 11:17:38 PST 2009


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 31601: Move showDebugBorders and showRepaintCounter to Settings/Preferences
https://bugs.webkit.org/show_bug.cgi?id=31601

Attachment 43442: Replacement patch - gets rid of errant printfs
https://bugs.webkit.org/attachment.cgi?id=43442&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 51121)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,38 @@
> +2009-11-18  Chris Marrin  <cmarrin at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Add Settings for WebKitShowDebugBorders and WebKitShowRepaintCounter

> +	   https://bugs.webkit.org/show_bug.cgi?id=31601
> +
> +	   These are used to debug accelerated compositing layers

Your changelog should mention stuff about moving them from GraphicsLayerCA to
GraphicsLayer, and plumbing them through the backing and compositor.

r=me


More information about the webkit-reviews mailing list