[webkit-reviews] review requested: [Bug 31601] Move showDebugBorders and showRepaintCounter to Settings/Preferences : [Attachment 43440] Patch

[bugzilla-daemon at webkit.org]

Chris Marrin <cmarrin at apple.com> has asked  for review:
Bug 31601: Move showDebugBorders and showRepaintCounter to Settings/Preferences
https://bugs.webkit.org/show_bug.cgi?id=31601

Attachment 43440: Patch
https://bugs.webkit.org/attachment.cgi?id=43440&action=review

------- Additional Comments from Chris Marrin <cmarrin at apple.com>
This adds prefs to WebKit and Settings to WebCore. You now use defaults write
with WebKitShowDebugBorders and WebKitShowRepaintCounter. You can do this while
WebKit is running. But since WebKit is not that great about reloading prefs,
you often need to do the defaults write twice and then turn on and off a Debug
flat (like Accelerated Compositing) and finally reload, to get the change to be
taken. Adding a Debug menu item to Safari to turn these on and off would fix
all this. Until then the best approach is to use defaults write and then
restart Safari. This is the same as today, so it shouldn't be a problem.