[webkit-reviews] review granted: [Bug 27552] remember last script displayed in Scripts panel : [Attachment 43433] proposed patch 2009/11/18 - a

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Patrick Mueller
<pmuellr at yahoo.com>'s request for review:
Bug 27552: remember last script displayed in Scripts panel
https://bugs.webkit.org/show_bug.cgi?id=27552

Attachment 43433: proposed patch 2009/11/18 - a
https://bugs.webkit.org/attachment.cgi?id=43433&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Looks good.
One comment though - you are using InspectorController.setting() in a sync
manner, whereas we are going away from that. We now think that there is agent
(with inspector backend) and a client (frontend). Interaction between those is
supposed to be serialized and asynchronous (imagine that remote client attaches
to the agent).

So we should either convert setting to async call with a callback or extract
such methods into another interface like InspectorHost. First seems to be
simpler.