[webkit-reviews] review granted: [Bug 31593] KURL removes trailing and leading spaces during init, but not newlines, carriage returns or tabs. : [Attachment 43427] Alternative Patch.

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ben Murdoch <benm at google.com>'s
request for review:
Bug 31593: KURL removes trailing and leading spaces during init, but not
newlines, carriage returns or tabs.
https://bugs.webkit.org/show_bug.cgi?id=31593

Attachment 43427: Alternative Patch.
https://bugs.webkit.org/attachment.cgi?id=43427&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   When retrieving the href attribute of an A tag, we should run the
attribute value through deprecatedParseURL until a good replacement for that
function is found.

That's not really a bug title. It would be better to describe the problem and
the real world symptom in both the bug and the change log.

This patch still seems too detached from what effect it's having on websites.
There's not even a mention of what other browsers do or what HTML5 prescribes.

The key here is to do the same work in the href function that is done in
HTMLAnchorElement::defaultEventHandler and
HTMLAnchorElement::parseMappedAttribute. And I think that's what the comment
should indicate. Consistency is the issue.

I would have liked to see more test cases about characters that should *not* be
stripped, such as non-breaking spaces, \v, and the like.

r=me as is, although I'm not super-happy with how this is described in the
change log