[webkit-reviews] review requested: [Bug 6021] WebKit+SVG does not support filterRes attribute : [Attachment 43422] Implementation of filterRes

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has asked  for review:
Bug 6021: WebKit+SVG does not support filterRes attribute
https://bugs.webkit.org/show_bug.cgi?id=6021

Attachment 43422: Implementation of filterRes
https://bugs.webkit.org/attachment.cgi?id=43422&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
This is the implementation of filterRes. It scales the intermediate images used
by the filter and it's effects to set the quality of a filter. It scales the
values of any filter effect if needed too. According to the Spec
(http://www.w3.org/TR/SVG11/filters.html#FilterUnitsAttribute) we can use
filterRes to limit the quality to the needs of the device. I limit the size, so
that the maximum size of any  intermediate image is 5000x5000 pixels. A didn't
tested the maximum value that is possible, but 10,000x10,000 crashed on cairo.
It is also a question of slowness not to have a to big limitation. This fixes
bug 26380.
Other platforms can use a different limitations. A maximum size of 200x200 or
100x100 is maybe enough for mobile devices.