[webkit-reviews] review denied: [Bug 31580] Rewrite the test fast/parser/comment-in-textarea to use dumpAsText : [Attachment 43352] Rewrite the test fast/parser/comment-in-textarea to use dumpAsText

Wed Nov 18 00:21:41 PST 2009

Dmitry Titov <dimich at chromium.org> has denied Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 31580: Rewrite the test fast/parser/comment-in-textarea to use dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=31580

Attachment 43352: Rewrite the test fast/parser/comment-in-textarea to use
dumpAsText
https://bugs.webkit.org/attachment.cgi?id=43352&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
Yeah! More 'dumpAsText' tests!

Few nits:

>  <html>
> -<body>
> -<textarea>
> +<head>

<head> doesn't really add to the test, could be removed.

> +    <script>
> +    function log(msg)

the <script> tag with content is usually not indented.

> +    }
> +    function test()

Could be nice to have an empty line between these.

r- because if you fix those, we'll just run it through commit-bot.