[webkit-reviews] review denied: [Bug 31578] [Chromium] Handle the prepended charset meta tag in the clipboard properly so that CnP works correctly : [Attachment 43348] Strip the special meta tag at the beginning of the copied HTML

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 31578: [Chromium] Handle the prepended charset meta tag in the clipboard
properly so that CnP works correctly
https://bugs.webkit.org/show_bug.cgi?id=31578

Attachment 43348: Strip the special meta tag at the beginning of the copied
HTML
https://bugs.webkit.org/attachment.cgi?id=43348&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Needs a ChangeLog.

> +    m_dataObject->textHtml = String("<meta charset='utf-8'
id='chromium-interchange-charset'>") + m_dataObject->textHtml;

should this be "chromium-" or "webkit-". Nitpicking, I know -- not a big deal
either way :)

> +	   DEFINE_STATIC_LOCAL(const String, forceUtf8String, ("<meta
charset='utf-8' id='chromium-interchange-charset'>"));
> +	   if (markup.startsWith(forceUtf8String)) {
> +	     markup = markup.substring(forceUtf8String.length());
> +	   }

No braces for one-line condition statements.