[webkit-reviews] review denied: [Bug 31593] KURL removes trailing and leading spaces during init, but not newlines, carriage returns or tabs. : [Attachment 43373] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 17 11:57:55 PST 2009


Darin Adler <darin at apple.com> has denied Ben Murdoch <benm at google.com>'s
request for review:
Bug 31593: KURL removes trailing and leading spaces during init, but not
newlines, carriage returns or tabs.
https://bugs.webkit.org/show_bug.cgi?id=31593

Attachment 43373: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=43373&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
There is insufficient context for this change. Does this affect websites? If
so, how? What is the motivation for this change? Website incompatibilities?
Behavior differences from other browsers?

This is too little test coverage. The new test covers only the newline
character.

"I think this should change" is interesting, but not sufficient motivation for
the change on its own.


More information about the webkit-reviews mailing list