[webkit-reviews] review denied: [Bug 31505] [GTK] Tab key does not cycle through elements by default : [Attachment 43222] Patch for this issue

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Martin Robinson
<martin.james.robinson at gmail.com>'s request for review:
Bug 31505: [GTK] Tab key does not cycle through elements by default
https://bugs.webkit.org/show_bug.cgi?id=31505

Attachment 43222: Patch for this issue
https://bugs.webkit.org/attachment.cgi?id=43222&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +	   el.focus();
> +	   if (window.eventSender) {
> +	       eventSender.keyDown("\t");
> +	   }

Braces.

>	   if (window.layoutTestController) {
>	       layoutTestController.dumpAsText();
> -	       // Set this preference so the tab key will actually insert a tab
character- like in Mail.
> +	   }

More braces? =)

> +	   if (window.layoutTestController) {
>	       layoutTestController.setTabKeyCyclesThroughElements(false);
>	   }

Ditto. There are some others.

Can you split the test from the translatable strings/param flags?