[webkit-reviews] review denied: [Bug 31583] [Qt] better test coverage for ErrorPageExtension : [Attachment 43357] patch 0.1

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Antonio Gomes
(tonikitoo) <tonikitoo at webkit.org>'s request for review:
Bug 31583: [Qt] better test coverage for ErrorPageExtension
https://bugs.webkit.org/show_bug.cgi?id=31583

Attachment 43357: patch 0.1
https://bugs.webkit.org/attachment.cgi?id=43357&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>

> +	   (tst_QWebPage::errorPageExtension_withIFrames):
> +	   (tst_QWebPage::errorPageExtension_withFrameset):

Strange function naming

>  void tst_QWebPage::infiniteLoopJS()
>  {
> +    return;

Doesn't seem right


> -    page->mainFrame()->load(QUrl("qrc:///frametest/index.html"));
> +    m_view->setUrl(QUrl("data:text/html,foo"));
> +    QTest::qWait(2000);

Can these waits be avoided?