[webkit-reviews] review denied: [Bug 31183] [Qt][Mac] flash plugin doesn't work when using QGraphicsWebView. : [Attachment 43280] Implement plugin rendering (3)

[bugzilla-daemon at webkit.org]

Girish Ramakrishnan <girish at forwardbias.in> has denied Girish Ramakrishnan
<girish at forwardbias.in>'s request for review:
Bug 31183: [Qt][Mac] flash plugin doesn't work when using QGraphicsWebView.
https://bugs.webkit.org/show_bug.cgi?id=31183

Attachment 43280: Implement plugin rendering (3)
https://bugs.webkit.org/attachment.cgi?id=43280&action=review

------- Additional Comments from Girish Ramakrishnan <girish at forwardbias.in>
Had a discussion with Tor Arne on irc:
1. Decided not to use off screen pixmap in all cases since performance
regression not acceptable.
2. Make the contextref code x-platform. Only the QPixmap code will be ifdef'ed
Qt.

Also, I have managed to get events working. But I will make that a separate
patch.

To get printing and rendering to image to work, we have to probe
painter->device(). I don't plan to implement this bit atm since it's not needed
for my customer.