[webkit-reviews] review granted: [Bug 31561] [Chromium] Support null NPObject* parameter in _NPN_SetException : [Attachment 43318] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 16 14:07:17 PST 2009
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 31561: [Chromium] Support null NPObject* parameter in _NPN_SetException
https://bugs.webkit.org/show_bug.cgi?id=31561
Attachment 43318: patch
https://bugs.webkit.org/attachment.cgi?id=43318&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/ChangeLog
...
> + Handle the case of a null NPObject* in NPN_SetException in
> + the V8 bindings.
I had to read the bug summary to understand this patch. It would be
good to put more of the justification for this change here in the
ChangeLog.
Otherwise, R=me
More information about the webkit-reviews
mailing list