[webkit-reviews] review denied: [Bug 31554] [Android] Android is missing the implementation of the GeolocationService iface. : [Attachment 43308] Android implementation of the GeolocationService implementation

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Andrei Popescu
<andreip at google.com>'s request for review:
Bug 31554: [Android] Android is missing the implementation of the
GeolocationService iface.
https://bugs.webkit.org/show_bug.cgi?id=31554

Attachment 43308: Android implementation of the GeolocationService
implementation
https://bugs.webkit.org/attachment.cgi?id=43308&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
> +// GeolocationServiceBridge is the bridge to the Java implementation. It
manages
> +// the lifetime of the Java object. It is an implementation detail of
> +// GeolocationServiceAndroid.
> +class GeolocationServiceBridge {

Can you split this out into a separate file?

> +    static PassRefPtr<Geoposition> convertLocationToGeoposition(JNIEnv *env,
const jobject &location);

toGeoposition is shorter and more inline with the WebKit convention.

> +static const char* kJavaGeolocationServiceClass =
"android/webkit/GeolocationService";

prefix k* is not necessary, just use standard camelCase.

> +enum kJavaGeolocationServiceClassMethods {
> +    GEOLOCATION_SERVICE_METHOD_INIT = 0,

GeolocationServiceMethodInit <-- casing here and elsewhere

> +    GEOLOCATION_SERVICE_METHOD_START,
> +    GEOLOCATION_SERVICE_METHOD_STOP,
> +    GEOLOCATION_SERVICE_METHOD_SET_ENABLE_GPS,
> +    GEOLOCATION_SERVICE_METHOD_COUNT,
> +};