[webkit-reviews] review granted: [Bug 31544] Move StyleQueue over to using PatchCollection : [Attachment 43292] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 16 04:26:10 PST 2009


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 31544: Move StyleQueue over to using PatchCollection
https://bugs.webkit.org/show_bug.cgi?id=31544

Attachment 43292: Patch
https://bugs.webkit.org/attachment.cgi?id=43292&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think add_all should be add_patches
add() doens't need to exist.

The tests will need to update names if you do that.

There is likely some super-slick python way to do this, by implementing the
right bits to be a sequence type, but that's more python than I know.  I'll CC
some python folks though and they can give post-landing comments if they
choose.


More information about the webkit-reviews mailing list