[webkit-reviews] review granted: [Bug 31513] Refactor bugzilla-tool to allow for multiple queues : [Attachment 43270] Arise WorkQueue

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 31513: Refactor bugzilla-tool to allow for multiple queues
https://bugs.webkit.org/show_bug.cgi?id=31513

Attachment 43270: Arise WorkQueue
https://bugs.webkit.org/attachment.cgi?id=43270&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
safe_to_proceed_with_work_item
maybe "should_proceed_with_work_item" would be better.

 862	     # We don't have a patch id at this point, so try to grab the first
patch off of the bug in question.

Would be better to update that comment to indicate that we plan to update the
commit-queue to opearate off of patch ids in the near future.

819		make_option("--status-host", action="store", type="string",
dest="status_host", default=StatusBot.default_host, help="Do not ask the user
for confirmation before running the queue.  Dangerous!"),
should probably move up into WorkQueue since it's used there.

_ensure_bug_log_closed

Seems like the wrong name for a generic queue.

_ensure_work_item_log_closed ?

This should eventually move to a new file.  It also eventually needs unit
tests.

I trust you to make those edits before commit.