[webkit-reviews] review denied: [Bug 31239] c3d test crash WebKit : [Attachment 43212] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 13 17:00:11 PST 2009
Oliver Hunt <oliver at apple.com> has denied Chris Marrin <cmarrin at apple.com>'s
request for review:
Bug 31239: c3d test crash WebKit
https://bugs.webkit.org/show_bug.cgi?id=31239
Attachment 43212: Patch
https://bugs.webkit.org/attachment.cgi?id=43212&action=review
------- Additional Comments from Oliver Hunt <oliver at apple.com>
Minor formatting bug
> +bool WebGLRenderingContext::validateIndexArray(unsigned long count, unsigned
long type, long offset, long& numElements)
> +{
...
> + }
> + else if
File a bug on createShader -- it will accept any non-FRAGMENT_SHADER value as
GL_VERTEX_SHADER
r- until there are testcases for all of these as well :-(
--Oliver
More information about the webkit-reviews
mailing list