[webkit-reviews] review granted: [Bug 31489] DOMHTMLSelectElement is missing some implementation : [Attachment 43200] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 13 15:04:33 PST 2009


mitz at webkit.org has granted Jon Honeycutt <jhoneycutt at apple.com>'s request for
review:
Bug 31489: DOMHTMLSelectElement is missing some implementation
https://bugs.webkit.org/show_bug.cgi?id=31489

Attachment 43200: patch
https://bugs.webkit.org/attachment.cgi?id=43200&action=review

------- Additional Comments from mitz at webkit.org
> +    ASSERT(m_element && m_element->hasTagName(selectTag));

Please split this assertion into two separate assertions.

> +    ASSERT(m_element && m_element->hasTagName(selectTag));

Ditto.


More information about the webkit-reviews mailing list