[webkit-reviews] review denied: [Bug 31401] [Qt] inputMethodState incorrect after autocompletion popup : [Attachment 43056] proposed fix for focuscontroller.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 13 13:42:01 PST 2009


Eric Seidel <eric at webkit.org> has denied Janne Koskinen <koshuin at gmail.com>'s
request for review:
Bug 31401: [Qt] inputMethodState incorrect after autocompletion popup
https://bugs.webkit.org/show_bug.cgi?id=31401

Attachment 43056: proposed fix for focuscontroller.cpp
https://bugs.webkit.org/attachment.cgi?id=43056&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Can this be tested?  r- for lack of test, or lack of explanation as to why it
can't be tested.  I don't really understand what this fix is trying to do, and
testing would help a reviewer understand the effect of this change.


More information about the webkit-reviews mailing list