[webkit-reviews] review granted: [Bug 31402] WebInspector: timeline-paint.html test fails on Windows and GTK+ platforms : [Attachment 43153] WebInspector: fixes timeline-paint.html test for Windows.

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Eric Ayers
<zundel at google.com>'s request for review:
Bug 31402: WebInspector: timeline-paint.html test fails on Windows and GTK+
platforms
https://bugs.webkit.org/show_bug.cgi?id=31402

Attachment 43153: WebInspector: fixes timeline-paint.html test for Windows.
https://bugs.webkit.org/attachment.cgi?id=43153&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +++ WebKitTools/DumpRenderTree/win/DumpRenderTree.cpp (working copy)
> @@ -286,7 +286,7 @@ static void initialize()
>  void displayWebView()
>  {
>      ::InvalidateRect(webViewWindow, 0, TRUE);
> -    ::UpdateWindow(webViewWindow);
> +    ::SendMessage(webViewWindow, WM_PAINT, 0, 0);
>  }

It would be good to add a comment here about why UpdateWindow doesn't work. It
would also be good to explain this in the ChangeLog.

In general I think you should explain all the changes you made in your
ChangeLog (e.g., the change to timelineNonDeterministicProps, the new call to
layoutTestController.display(), the removal of isTimelineOverheadRecord(),
etc.)

r=me, though, even if you don't add those comments. But I really think you
should!