[webkit-reviews] review requested: [Bug 31468] Unify TextBoundaries implementations by only relying on WTF Unicode abstractions : [Attachment 43157] Refactoring TextBoundariesICU.cpp into generic TextBoundaries.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Nov 13 08:28:51 PST 2009


Dominik Röttsches <dominik.roettsches at access-company.com> has asked  for
review:
Bug 31468: Unify TextBoundaries implementations by only relying on WTF Unicode
abstractions
https://bugs.webkit.org/show_bug.cgi?id=31468

Attachment 43157: Refactoring TextBoundariesICU.cpp into generic
TextBoundaries.cpp
https://bugs.webkit.org/attachment.cgi?id=43157&action=review

------- Additional Comments from Dominik Röttsches
<dominik.roettsches at access-company.com>
TextBoundaries.cpp intends to be equivalent to the TextBoundariesICU.cpp but is
relying on internal abstractions. 
Removing unneeded ICU includes in SimpleFontDataGtk.cpp on the way.

I did not try to merge the Qt version of TextBoundaries.cpp - could someone
from the Qt WebKit team look at whether that's desired? Who would be best CC'ed
on this bug regarding this question?


More information about the webkit-reviews mailing list