[webkit-reviews] review denied: [Bug 31266] [Qt] QWebSettings::setMaximumPagesInCache(int pages) does not enable the Page Cache : [Attachment 42998] simlified patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Andras Becsi
<becsi.andras at stud.u-szeged.hu>'s request for review:
Bug 31266: [Qt] QWebSettings::setMaximumPagesInCache(int pages) does not enable
the Page Cache
https://bugs.webkit.org/show_bug.cgi?id=31266

Attachment 42998: simlified patch
https://bugs.webkit.org/attachment.cgi?id=42998&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
The patch looks good to me, except for this piece:

> +    settings()->setMaximumPagesInCache(0); // reset to default
>  }
[...]  
> +    else if (name == "WebKitUsesPageCachePreferenceKey")
> +	   settings->setMaximumPagesInCache(value.toInt());
>  }

setMaximumPagesInCache is a class method of QWebSettings, so the code should
read

QWebSettings::setMaximumPagesInCache()

It is currently not possible to specify this per settings object after all,
only globally.